You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 15, 2021. It is now read-only.
I've added a Dockerfile with a start script to either run the web server or use in CLI mode.
I've also included a markdown readme that should work just like the RST version. Pretty sure it will work with PyPI, but if not, I left the original intact. Github will use the markdown version.
Hi progrium,
What is the practical use of running the web server from a Docker container?
Do you expect the users to have the webapp listening on IP addresses other than the localhost? If so, exposing the raw contents of /proc to other (unauthenticated) hosts is a significant security risk.
That's really up to the user. The use is for internal, so either localhost
or an internal IP. Also, running inside a container gives you a fairly
limited version of /proc anyway, so you don't actually get full access to
/proc, but enough for basic system introspection.
Hi progrium,
What is the practical use of running the web server from a Docker
container?
Do you expect the users to have the webapp listening on IP addresses other
than the localhost? If so, exposing the raw contents of /proc to other
(unauthenticated) hosts is a significant security risk.
—
Reply to this email directly or view it on GitHub #14 (comment).
I strongly disagree with adding a dockerfile to this python module, I use procfs just for parsing the /proc directory in python. This seems not related to the module and more of a personal preference. How will this benefit the users currently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a Dockerfile with a start script to either run the web server or use in CLI mode.
I've also included a markdown readme that should work just like the RST version. Pretty sure it will work with PyPI, but if not, I left the original intact. Github will use the markdown version.